Fix namespace extension to support latest Sinatra version #207
Conversation
Amazing! See the errors on travis: |
Thanks @stjhimy! The
But the latest version of
What do you think is the best way to resolve it? |
zdfnaksdjfasjdf;laskdjfpoiasdjfasdf THANK YOU!!! I can't believe the fix was this easy, and have been pining over this for literally weeks. |
@304 @stjhimy Ahh, yeah there is an issue when using regular expression in the path. If we don't skip
|
@zzak yes, this is the one we must patch |
The following specs are still failing: https://github.com/sinatra/sinatra-contrib/blob/9500d76/spec/namespace_spec.rb#L170-L209 /cc #200 and #207
Fix namespace extension to support latest Sinatra version
Since master has a patch which fixes the missing `:+` implementation for Regular and Sinatra-based patterns. We can also re-enable the namespace specs for accepting regular expressions for path concatination. /cc sinatra#200 and sinatra#207
The following specs are still failing: https://github.com/sinatra/sinatra-contrib/blob/9500d76/spec/namespace_spec.rb#L170-L209 /cc sinatra#200 and sinatra#207
This fix should resolve some of the issues with namespace extension.
I haven't worked with this extension before, so I was completely relying on tests during my investigation. Please feel free to comment.
Issue: #200