-
Notifications
You must be signed in to change notification settings - Fork 219
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
24 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7617305
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rkh Shouldn't we offer reloader as the default, and rerun as an alternative? I hadn't even heard of rerun and was confused by the confusion in this Rogues episode. http://rubyrogues.com/116-rr-non-rails-projects/ (about 20:00:00).
I'll rewrite if agreeable.
7617305
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... dunno. I actually think rerun is the better solution.
7617305
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never had an issue with
Sinatra::Reloader
, but what does everyone think of deprecating it to the oldsinatra-reloader
gem and cleaning upcontrib
a little?7617305
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um, wait, I don't think it's an issue with the sinatra-contrib reloader vs the old reloader, but more about in-process reloading not working very well in Ruby.
7617305
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rkh I mean to move it out of sinatra-contrib, those that want (and can) use it will need to install sinatra-reloader.
This will help us in the sense that we no longer deal with it in
contrib
. But the problem still exists in Ruby.