rack.sessions.options no longer contains :secret in 1.3

sinatra · May 3, 2011 · d0df5fb · d0df5fb
1 parent 01ae70e
commit d0df5fb
Showing 1 changed file with 30 additions and 28 deletions.
diff --git a/test/helpers_test.rb b/test/helpers_test.rb
@@ -298,34 +298,36 @@ def test_default
       assert_body 'ok'
     end
 
-    it 'sets a default session secret' do
-      mock_app do
-        enable :sessions
-        get '/' do
-          secret = env['rack.session.options'][:secret]
-          assert secret
-          assert_equal secret, settings.session_secret
-          'ok'
-        end
-      end
-
-      get '/'
-      assert_body 'ok'
-    end
-
-    it 'allows disabling session secret' do
-      mock_app do
-        enable :sessions
-        disable :session_secret
-        get '/' do
-          assert !env['rack.session.options'].include?(:session_secret)
-          'ok'
-        end
-      end
-
-      get '/'
-      assert_body 'ok'
-    end
+    # # have to write proper tests or remove those, since they no longer work
+    # # on Rack 1.3
+    # it 'sets a default session secret' do
+    #   mock_app do
+    #     enable :sessions
+    #     get '/' do
+    #       secret = env['rack.session.options'][:secret]
+    #       assert secret
+    #       assert_equal secret, settings.session_secret
+    #       'ok'
+    #     end
+    #   end
+    #
+    #   get '/'
+    #   assert_body 'ok'
+    # end
+    #
+    # it 'allows disabling session secret' do
+    #   mock_app do
+    #     enable :sessions
+    #     disable :session_secret
+    #     get '/' do
+    #       assert !env['rack.session.options'].include?(:session_secret)
+    #       'ok'
+    #     end
+    #   end
+    #
+    #   get '/'
+    #   assert_body 'ok'
+    # end
 
     it 'accepts an options hash' do
       mock_app do