Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sinatra::Contrib dependency updates. Fixes #1207 #1411

Merged
merged 2 commits into from Mar 13, 2020
Merged

Sinatra::Contrib dependency updates. Fixes #1207 #1411

merged 2 commits into from Mar 13, 2020

Conversation

@namusyaka
Copy link
Contributor

@namusyaka namusyaka commented Mar 19, 2018

  • Remove backports
  • Work around Object#try and String#underscore
* Remove backports
* Work around Object#try and String#underscore
@namusyaka namusyaka added this to the v2.1.0 milestone Mar 19, 2018
@jkowens
Copy link
Member

@jkowens jkowens commented Aug 27, 2019

@namusyaka I'm not quite sure what the status of this issue is because it looks like another fix was partially merged. There still appears to be somebackports remnants in the codebase. Is the plan to rebase this PR and merge at some point?

@jkowens jkowens closed this Mar 11, 2020
@jkowens jkowens reopened this Mar 11, 2020
@jkowens jkowens merged commit 8ddf4f9 into master Mar 13, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jkowens jkowens deleted the fix-1207 branch Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.