Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in the Combine API #39

Merged
merged 3 commits into from
Apr 5, 2020
Merged

Fix crash in the Combine API #39

merged 3 commits into from
Apr 5, 2020

Conversation

fredyshox
Copy link
Contributor

@fredyshox fredyshox commented Apr 4, 2020 •
edited by sindresorhus
Loading

Attempt to fix #38

@fredyshox fredyshox marked this pull request as ready for review April 4, 2020 21:06
@fredyshox
Copy link
Contributor Author

Summary: Moved observation.start to separate function in DefaultsSubscription, and called after receiving subscription, which fixed issue.

@fredyshox fredyshox mentioned this pull request Apr 4, 2020
Closed
@sindresorhus sindresorhus changed the title Combine API Bug: Received value before receiving subscription Fix crash in the Combine API Apr 5, 2020
@sindresorhus sindresorhus merged commit 3275717 into sindresorhus:master Apr 5, 2020
@sindresorhus
Copy link
Owner

Thanks for fixing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash in Observation+Combine l.36
2 participants
@fredyshox @sindresorhus