Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type for "mods" requires all properties to be defined #147

Closed
rchl opened this issue Dec 9, 2021 · 0 comments · Fixed by #148
Closed

Type for "mods" requires all properties to be defined #147

rchl opened this issue Dec 9, 2021 · 0 comments · Fixed by #148

Comments

@rchl
Copy link
Contributor

rchl commented Dec 9, 2021

This type:

alfy/index.d.ts

Line 235 in 2e08f6d

readonly mods?: Record<PossibleModifiers, ModifierKeyItem>;

is wrong since it doesn't allow specifying just some of the key modifier handlers. All need to be specified with that type.

Screenshot 2021-12-09 at 22 11 04

Error: Type '{ shift: { subtitle: string; }; }' is missing the following properties from type 'Record<PossibleModifiers, ModifierKeyItem>': fn, ctrl, opt, cmd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant