This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
fix security issue #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 |
|
LGTM and release a new build. 👍 |
sindresorhus
force-pushed
the
fix-websecurity
branch
2 times, most recently
from
aa463bc
to
995d867
Compare
fixes #67
This was the only way to not trigger CSP.
|
Alright. I found a much better solution, thanks to comments in electron/electron#5671. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #67
This was the only way to not trigger CSP (webSecurity) violation.
// @paulmolluzzo @danhp
We can remove the concat hack when electron/electron#5671 is out.