This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Move OS class creation and darkMode init to after React loads #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting a couple of console errors and I fixed them by moving some things into the
init()
function which depends on React being ready. Specifically I moved adding the OS-specific class name to thedocument
, and I also moveddarkMode()
since that depends on the DOM being ready.See if you can replicate the errors on
master
, then test this branch. All I did was start the app and it occurred every time.Errors: