refactor: remark-lint:awesome-github #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapyu
commented
Dec 24, 2023
| @@ -65,7 +65,7 @@ const githubRule = lintRule('remark-lint:awesome-github', async (ast, file) => { | |||
| file.message('License was not detected by GitHub'); | |||
| } | |||
| } catch { | |||
| file.message('Awesome list must reside in a valid git repository'); | |||
| file.message('.git/ directory not found'); | |||
There was a problem hiding this comment.
I propose to change "Awesome list must reside in a valid git repository" to ".git/ directory not found'" in order to make it clearer.
There was a problem hiding this comment.
I don't think this is better.
sindresorhus
reviewed
Jan 7, 2024
| @@ -20,7 +20,7 @@ Includes a bunch of [general Markdown rules](config.js) and some [Awesome specif | |||
|
|
|||
| The CLI requires Node.js and Git. | |||
|
|
|||
| Type the command `npx awesome-lint` followed by the URL of the repo you want to check: | |||
| In a git directory, type the command `npx awesome-lint` followed by the URL of the repo you want to check: | |||
There was a problem hiding this comment.
This becomes moot with #180 (comment)
|
I think it's better to properly fix the issue: #180 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180
I accidentally deleted the repository used to create the PR #181 . That is why I opened a new one with the same proposals :)