-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remark-lint:awesome-github #182
Conversation
@@ -65,7 +65,7 @@ const githubRule = lintRule('remark-lint:awesome-github', async (ast, file) => { | |||
file.message('License was not detected by GitHub'); | |||
} | |||
} catch { | |||
file.message('Awesome list must reside in a valid git repository'); | |||
file.message('.git/ directory not found'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to change "Awesome list must reside in a valid git repository" to ".git/ directory not found'" in order to make it clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is better.
@@ -20,7 +20,7 @@ Includes a bunch of [general Markdown rules](config.js) and some [Awesome specif | |||
|
|||
The CLI requires Node.js and Git. | |||
|
|||
Type the command `npx awesome-lint` followed by the URL of the repo you want to check: | |||
In a git directory, type the command `npx awesome-lint` followed by the URL of the repo you want to check: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This becomes moot with #180 (comment)
I think it's better to properly fix the issue: #180 (comment) |
Closes #180
I accidentally deleted the repository used to create the PR #181 . That is why I opened a new one with the same proposals :)