Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parasite #1341

Merged
merged 2 commits into from Jan 26, 2019
Merged

Add Parasite #1341

merged 2 commits into from Jan 26, 2019

Conversation

arw36
Copy link
Contributor

@arw36 arw36 commented Jun 23, 2018

https://github.com/ecohealthalliance/awesome-parasite/

A curated list of awesome information and open-access databases related to parasites and host-pathogen interactions.

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Requirements for your pull request

  • I have read and understood the contribution guidelines and the instructions for creating a list.
  • This pull request has a descriptive title.
    For example, Add Name of List, not Update readme.md or Add awesome list.
  • The entry in the Awesome list should:
    • Include a short description about the project/theme of the list. It should not describe the list itself.
      Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
    • Be added at the bottom of the appropriate category.
  • The list I'm submitting complies with these requirements:

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • It's the result of hard work and the best I could possibly produce.
  • Non-generated Markdown file in a GitHub repo.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Includes a project logo/illustration whenever possible.
    • Either fullwidth or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of sub-lists, preferably none.
  • Has an appropriate license.
    • That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
    • WTFPL and Unlicense are not acceptable licenses.
    • If you use a license badge, it should be SVG, not PNG.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

Copy link
Contributor

@anotterdev anotterdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not satisfy the repo age requirement yet, but other than that looks good to me

@sindresorhus
Copy link
Owner

Hey, sorry for the lack of response, please see #1363.

@arw36
Copy link
Contributor Author

arw36 commented Jul 29, 2018

Thanks for response @sindresorhus. I agree with your points in #1363. I have reviewed #1308, #1321, #1300. Also, the repo has now been open-sourced for >30 days. Let me know if there's anything else I should do.

readme.md Outdated
@@ -577,6 +577,7 @@
- [Visual Regression Testing](https://github.com/mojoaxel/awesome-regression-testing) - Ensures changes did not break the functionality or style.
- [Theravada](https://github.com/johnjago/awesome-theravada) - Teachings from the Theravada Buddhist tradition.
- [inspectIT](https://github.com/inspectit-labs/awesome-inspectit) - Open source Java app performance management tool.
- [Parasite](https://github.com/ecohealthalliance/awesome-parasite) - Resources for parasites and host-pathogen interactions.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry in the Awesome list should:
Include a short description about the project/theme of the list. It should not describe the list itself.

⬆️

@sindresorhus sindresorhus changed the title Add Awesome Parasite Add Parasite Aug 17, 2018
@sindresorhus
Copy link
Owner

If you use a license badge, it should be SVG, not PNG.

⬆️

@sindresorhus
Copy link
Owner

The heading should either be awesome-parasite or Awesome Parasite, preferably the latter.

@sindresorhus
Copy link
Owner

Includes a succinct description of the project/theme at the top of the readme. (Example)

⬆️

@sindresorhus
Copy link
Owner

Interesting topic! :)

@tindzk
Copy link
Contributor

tindzk commented Aug 26, 2018

Three remarks:

  • The first item is not correctly formatted ("Olival et al. 2017 - Mammal-virus database with analysis.")
  • Create a separate section for the licence
  • Rebase your branch

arw36 pushed a commit to arw36/awesome-parasite that referenced this pull request Aug 31, 2018
add helmithR link, rearrange Olival et al. link and add license link per sindresorhus/awesome#1341 (comment)
arw36 pushed a commit to arw36/awesome-parasite that referenced this pull request Aug 31, 2018
add helmithR link, rearrange Olival et al. link and add license link per sindresorhus/awesome#1341 (comment)
@arw36
Copy link
Contributor Author

arw36 commented Sep 14, 2018

Thank you for edits @sindresorhus and @tindzk. I have addressed these issues and committed the changes.

@sindresorhus
Copy link
Owner

If you use a license badge, it should be SVG, not PNG.

This is not fixed.

@sindresorhus
Copy link
Owner

Also look at your diff (https://github.com/sindresorhus/awesome/pull/1341/files), you didn't correctly rebase.

@noamross
Copy link

(Pinch hitting for a very busy @arw36)

I've changed the the CC badge to SVG, rebased this branch and changed the link to the new, anchored format.

@sindresorhus sindresorhus merged commit 239090b into sindresorhus:master Jan 26, 2019
@sindresorhus
Copy link
Owner

Thanks! Nice to have more non-code type Awesome lists 👌

@sindresorhus
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants