New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lit-html #1357
Add lit-html #1357
Conversation
I think need to add some descriptions for the items in Implementations, Components and Starter Templates. I'll see if i have some time tonight to add some descriptions for the items. @web-padawan |
@sindresorhus This one should be good to go, i reviewed according all the guidelines and made changes/additions where needed, you can see changes here web-padawan/awesome-lit#3 |
@thepassle You didn't follow the specified format:
|
|
⬆️ |
Fixed here: web-padawan/awesome-lit#4
@sindresorhus fix has been merged |
@sindresorhus thanks for the feedback! The repo is now updated, thanks for @thepassle for his great work. There is no "official" logo yet, but hopefully it should not block merging this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fails awesome-lint
. Please go back and make sure you're following all of the suggested guidelines.
The most frequent issue you have is that your list item descriptions need to start with proper casing (generally an upper-case letter).
✖ 1:1 License section must be at heading depth 2 awesome/license
✖ 9:1 ToC missing item for "Other awesome resources" awesome/toc
✖ 30:59 List item link and description must be separated with a dash awesome/list-item
✖ 30:71 Remove trailing slash (https://polymer-slack.herokuapp.com) no-url-trailing-slash
✖ 36:65 List item description must start with valid casing awesome/list-item
✖ 37:47 List item description must start with valid casing awesome/list-item
✖ 38:56 List item description must start with valid casing awesome/list-item
✖ 39:62 List item description must start with valid casing awesome/list-item
✖ 40:50 List item description must start with valid casing awesome/list-item
✖ 41:68 List item description must start with valid casing awesome/list-item
✖ 42:69 List item description must start with valid casing awesome/list-item
✖ 43:67 List item description must start with valid casing awesome/list-item
✖ 44:68 List item description must start with valid casing awesome/list-item
✖ 45:85 List item description must start with valid casing awesome/list-item
✖ 46:58 List item description must start with valid casing awesome/list-item
✖ 50:103 List item description must start with valid casing awesome/list-item
✖ 51:62 List item description must start with valid casing awesome/list-item
✖ 55:64 List item description must start with valid casing awesome/list-item
✖ 56:64 List item description must start with valid casing awesome/list-item
✖ 60:69 List item description must start with valid casing awesome/list-item
✖ 61:90 List item description must start with valid casing awesome/list-item
✖ 66:110 List item description must start with valid casing awesome/list-item
✖ 67:103 List item description must start with valid casing awesome/list-item
✖ 68:55 List item description must start with valid casing awesome/list-item
✖ 69:73 List item description must start with valid casing awesome/list-item
✖ 70:50 List item description must start with valid casing awesome/list-item
✖ 82:188 List item link and description must be separated with a dash awesome/list-item
✖ 96:48 List item description must start with valid casing awesome/list-item
Updated the repo to fix |
A gentle ping to @sindresorhus regarding this PR. Please note that I have reviewed #1393 and #1395 today, to satisfy the code review requirement. |
The awesome list for lit-html has been merged in sindresorhus/awesome#1357 Please consider adding this badge, so as we could help more people with blog posts, tools etc.
The awesome list for lit-html has been approved in sindresorhus/awesome#1357 Please consider adding this badge, so as we could help more people with blog posts, tools etc.
The awesome list for lit-html has been merged in sindresorhus/awesome#1357 Please consider adding this badge, so as we could help more people with blog posts, tools etc.
https://github.com/web-padawan/awesome-lit-html#readme
A curated list of awesome lit-html resources. lit-html — an efficient, expressive, extensible HTML templating library for JavaScript.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
For example,
Add Name of List
, notUpdate readme.md
orAdd awesome list
.Example:
- [Fish](…) - User-friendly shell.
, not- [Fish](…) - Resources for Fish.
.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Go to the top and read it again.
This change is