Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roadmaps #1499

Merged
merged 2 commits into from May 13, 2019
Merged

Add Roadmaps #1499

merged 2 commits into from May 13, 2019

Conversation

liuchong
Copy link
Contributor

Add https://github.com/liuchong/awesome-roadmap

I've just made a collection of roadmaps, will add more in the following days.

Also I've found an issue #1470 refer to this, so I'd like to share my list here.

@liuchong liuchong changed the title Update readme.md Add Awesome Roadmap Jan 13, 2019
@ugurozturk
Copy link

@liuchong

Requirements for your Awesome list
Has been around for at least 30 days.
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.

@liuchong
Copy link
Contributor Author

Thanks, I've just made some updates on README.md to fit the contribution guidelines format, and will improve the list in the waiting 30 days 😹

@damccorm
Copy link

Outside of the waiting period, this looks like it now conforms to the style guide and is a cool list. Once its been around 30 days (aka early February) I'd vote to merge this in.

@alexk111
Copy link
Contributor

Thanks for the list!

Has been around for at least 30 days.

It was already mentioned :)

Has contribution guidelines. People who are contributing to your list should have a clear understanding of how they should do so.

contributing.md doesn't have any contribution guidelines.

Consistent and correct naming. For example, Node.js, not NodeJS or node.js

Double-check this. Vue is Vue.js: https://vuejs.org/

@liuchong
Copy link
Contributor Author

@alexk111 Thanks for pointing out the problems!
I've just filled contributing.md, and fixed name of VUE.JS in item description, but did not change the link, as it is exactly the project name.

@alexk111
Copy link
Contributor

I'm not sure that VUE.JS is correct. I believe the correct one is Vue.js. Check the top-left corner at https://vuejs.org.

@liuchong
Copy link
Contributor Author

VUE.JS is in the center of https://vuejs.org.
But it ok, let's use Vue.js.

@alexk111
Copy link
Contributor

This is a style for all the buttons in the center. Just checked their repo - the correct one is definitely Vue.js.

Thanks for the corrections! 👍

@liuchong liuchong force-pushed the patch-1 branch 2 times, most recently from 973e79d to f5ea688 Compare February 15, 2019 11:44
@liuchong
Copy link
Contributor Author

30 days passed, I have rebased my pull request branch to slove conflicts, could you check it again to see if it acceptable now?

@sindresorhus
Copy link
Owner

❯ awesome-lint https://github.com/liuchong/awesome-roadmap
✖ Linting

  README.md:9:3
  ✖   1:20   Invalid badge source                                    remark-lint:awesome/badge
  ✖   9:3    Incorrect indentation before bullet: remove 2 spaces    remark-lint:list-item-bullet-indent
  ✖  10:3    Incorrect indentation before bullet: remove 2 spaces    remark-lint:list-item-bullet-indent
  ✖  11:3    Incorrect indentation before bullet: remove 2 spaces    remark-lint:list-item-bullet-indent
  ✖  12:3    Incorrect indentation before bullet: remove 2 spaces    remark-lint:list-item-bullet-indent
  ✖  13:3    Incorrect indentation before bullet: remove 2 spaces    remark-lint:list-item-bullet-indent
  ✖  14:3    Incorrect indentation before bullet: remove 2 spaces    remark-lint:list-item-bullet-indent
  ✖  15:3    Incorrect indentation before bullet: remove 2 spaces    remark-lint:list-item-bullet-indent
  ✖  18:121  List item description must end with proper punctuation  remark-lint:awesome/list-item
  ✖  19:132  List item description must end with proper punctuation  remark-lint:awesome/list-item
  ✖  21:153  List item description must end with proper punctuation  remark-lint:awesome/list-item
  ✖  39:17   Remove empty section: "Miscellaneous"                   remark-lint:no-empty-sections

  12 errors

https://github.com/sindresorhus/awesome-lint

@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@sindresorhus
Copy link
Owner

sindresorhus commented Feb 26, 2019

This pull request has a descriptive title in the format Add Name of List (Example: Add Swift), not Update readme.md or Add awesome list.

@sindresorhus
Copy link
Owner

Includes a succinct description of the project/theme at the top of the readme. (Example)

readme.md Outdated Show resolved Hide resolved
@liuchong liuchong changed the title Add Awesome Roadmap Add Roadmap Feb 27, 2019
@liuchong liuchong changed the title Add Roadmap Add Roadmaps Feb 27, 2019
@liuchong
Copy link
Contributor Author

Ok, I have fixed the lint errors and merge confilcts, please check again, thanks.

@liuchong liuchong force-pushed the patch-1 branch 2 times, most recently from 2a332bf to cca11cc Compare March 3, 2019 15:32
@liuchong
Copy link
Contributor Author

liuchong commented Mar 3, 2019

@sindresorhus rebased again 😹

@MoienTajik
Copy link

Ping! Why this is not merged yet? I think this is a useful one.

@liuchong
Copy link
Contributor Author

Hi @sindresorhus , several months passed, would this ok to merge?

@sindresorhus
Copy link
Owner

🚀 iOS Developer Roadmap => iOS Developer Roadmap

To give you an overview of the core skills needed in data science. => Gives you an overview of the core skills needed in data science.

readme.md Outdated Show resolved Hide resolved
liuchong added a commit to liuchong/awesome-roadmaps that referenced this pull request May 9, 2019
@liuchong
Copy link
Contributor Author

liuchong commented May 9, 2019

Thanks for the thoroughly check, the issue are fixed now 💯

@sindresorhus sindresorhus merged commit 951a9f6 into sindresorhus:master May 13, 2019
@sindresorhus
Copy link
Owner

Tweet: https://twitter.com/awesome__re/status/1127792300933795840

@liuchong
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants