Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing.md #2834

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

VivekGuruduttK28
Copy link
Contributor

[Insert URL to the list here]
N/A

[Explain what this list is about and why it should be included here]
list guidelines-->list of guidelines
Fixed the typo.

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Requirements for your pull request

  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it. Instead use #2242 for incubation visibility.
  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
  • You have read and understood the instructions for creating a list.

All the below section wouldnt apply because this is a typo fix

list guidelines-->list of guidelines
Fixed the typo.
@sindresorhus sindresorhus merged commit 4abe2c0 into sindresorhus:main Oct 26, 2023
@Jogai
Copy link

Jogai commented Oct 27, 2023

"List guidelines" was imo referring to all the guidelines of the list, which also include awesome.md and contributing.md. "List of guidelines" changes the meaning to only the guidelines as stated in the pr template. In my opinion therefore this change was unnecessary, but I might be wrong because english is not my native language.

Arthur-xu added a commit to Arthur-xu/awesome that referenced this pull request Nov 13, 2023
* Add Steam Deck (sindresorhus#2743)

* Update link to Awesome Mastodon (sindresorhus#2739)

* Add Pest (sindresorhus#2601)

* Add HPC (sindresorhus#2640)

* Update guidelines

* Add Biological Image Analysis (sindresorhus#2620)

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

* Move Esolangs into "Programming Languages" section (sindresorhus#2799)

* Add Prompt Injection (sindresorhus#2734)

* Meta tweaks

* Add Complexity (sindresorhus#2389)

* Fix typo (sindresorhus#2834)

* Fix typos (sindresorhus#2835)

* Meta tweaks

---------

Co-authored-by: Francesco Sardone <francesco@airscript.it>
Co-authored-by: Edwin Kofler <edwin@kofler.dev>
Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
Co-authored-by: akail <andrew.a.kail@gmail.com>
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Co-authored-by: Hallvard A. Wæhler <60000604+hallvaaw@users.noreply.github.com>
Co-authored-by: Sam Partington <sampart@github.com>
Co-authored-by: Hazana <hazanasec@gmail.com>
Co-authored-by: Diamantis Sellis <sellisd@gmail.com>
Co-authored-by: Vivek Gurudutt K <127002789+VivekGuruduttK28@users.noreply.github.com>
Co-authored-by: S A G A R <110724849+tmsagarofficial@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants