Fix unicode support on Windows #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@notatestuser @xconverge Can you test and confirm it's working? |
|
is there code for the binary here somewhere? |
|
@xconverge Yes, see the above link. |
|
Woops sorry didn't see it! I'll test it on Windows tomorrow! |
|
This looks good on my machine! Thanks a lot for the quick turnaround, this is going to be help out a lot |
|
Hooray - great to see you've finally acknowledged this as an issue after my ticket got ninja-closed 5 months ago. This works for me. |
|
@notatestuser Sorry about that. I get 100+ issues a week, of which 95% are invalid. I took a closer look this time as two people encountering something is a sign that it actually is an issue, and @xconverge provided manual steps to reproduce, which made it easy for me to confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to code my own binaries as existing hacks were just too slow and fragile.
https://github.com/sindresorhus/win-clipboard
Fixes #11
Fixes #2
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor