-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unicode support on Windows #13
Conversation
@notatestuser @xconverge Can you test and confirm it's working? |
is there code for the binary here somewhere? |
@xconverge Yes, see the above link. |
Woops sorry didn't see it! I'll test it on Windows tomorrow! |
This looks good on my machine! Thanks a lot for the quick turnaround, this is going to be help out a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦄
Hooray - great to see you've finally acknowledged this as an issue after my ticket got ninja-closed 5 months ago. This works for me. |
@notatestuser Sorry about that. I get 100+ issues a week, of which 95% are invalid. I took a closer look this time as two people encountering something is a sign that it actually is an issue, and @xconverge provided manual steps to reproduce, which made it easy for me to confirm. |
I decided to code my own binaries as existing hacks were just too slow and fragile.
https://github.com/sindresorhus/win-clipboard
Fixes #11
Fixes #2
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor