Skip to content

Commit

Permalink
Fix validation being incorrectly run before schema change (#194)
Browse files Browse the repository at this point in the history
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
  • Loading branch information
dopry and sindresorhus committed Jun 22, 2024
1 parent a3c288b commit 529e762
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions source/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,16 @@ export default class Conf<T extends Record<string, any> = Record<string, unknown

const fileStore = this.store;
const store = Object.assign(createPlainObject(), options.defaults, fileStore);

if (options.migrations) {
if (!options.projectVersion) {
throw new Error('Please specify the `projectVersion` option.');
}

this._migrate(options.migrations, options.projectVersion, options.beforeEachMigration);
}

// We defer validation until after migrations are applied so that the store can be updated to the current schema.
this._validate(store);

try {
Expand All @@ -148,14 +158,6 @@ export default class Conf<T extends Record<string, any> = Record<string, unknown
if (options.watch) {
this._watch();
}

if (options.migrations) {
if (!options.projectVersion) {
throw new Error('Please specify the `projectVersion` option.');
}

this._migrate(options.migrations, options.projectVersion, options.beforeEachMigration);
}
}

/**
Expand Down

0 comments on commit 529e762

Please sign in to comment.