Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the -nodejs suffix configurable #36

Closed
wants to merge 1 commit into from
Closed

Make the -nodejs suffix configurable #36

wants to merge 1 commit into from

Conversation

MegaGM
Copy link

@MegaGM MegaGM commented Mar 25, 2018

Fixes #35

Copy link
Contributor

@SamVerschueren SamVerschueren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be added to the documentation as well in the readme.

@sindresorhus
Copy link
Owner

This PR needs a proper title.

@MegaGM MegaGM changed the title fixes #35 Make the -nodejs suffix configurable fixes #35 Apr 2, 2018
@sindresorhus sindresorhus changed the title Make the -nodejs suffix configurable fixes #35 Make the -nodejs suffix configurable Apr 3, 2018
@sindresorhus
Copy link
Owner

@MegaGM Would you be able to document it? Also, include your use-case about wanting to use to the same store for both Node.js and Electron, so it's clear to users what they would use the option for.

Would also be great if you could include a test. You could do something similar to

conf/test.js

Line 158 in d22f823

t.true(conf.path.includes('conf'));
by just checking that the .path property include your chosen suffix.

@sindresorhus
Copy link
Owner

Friendly ping :)

JosephusPaye added a commit to JosephusPaye/conf that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants