Fix isPrototypeOf assert

[maxcnunes]

No description provided.

[novemberborn]

This package tracks https://nodejs.org/api/assert.html. The return false change was made intentionally: nodejs/node#4166

Without thinking too hard about your change, it should be dealt with in Node.js first before it can land here.

[maxcnunes]

Alright, if (Error.isPrototypeOf(expected)) was included to accommodate ES6 classes that extend Error. But that should return true instead of false. Or I am misunderstanding that code really badly 😕
I will bubble this up to node project.

[novemberborn]

Note that even if this line is correct, there might be something else out of sync between this module and Node.js itself.

That said, with regards to AVA, we won't be adding workarounds for core-asserts behavior, since we need to move away from it entirely. All we can do here is bring core-assert in line with Node.js.

[maxcnunes]

Ok. So lets close it and I can open another issue in case the Node assert module gets updated.