-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path to onProgress event #155
Conversation
readme.md
Outdated
} | ||
``` | ||
|
||
- `percent` is a value between `0` and `1` | ||
- `path` will not be present if no files were deleted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing in the TS doc comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it should describe what it is, like in the TS docs. They should be in sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in a8b391e
index.d.ts
Outdated
@@ -15,6 +15,11 @@ export interface ProgressData { | |||
Completed percentage. A value between `0` and `1`. | |||
*/ | |||
readonly percent: number; | |||
|
|||
/** | |||
Path of deleted file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From onProgress docs:
Called after each file or directory is deleted.
So it could be a directory too.
It would also be useful to make it clear it's an "absolute path".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in a8b391e
PR feedback has been addressed, and builds are passing. This is ready for re-review. |
Add the path of the deleted file to the
onProgress
event. Fixes #154