Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-skip-test rule #3

Closed
sindresorhus opened this issue Jan 15, 2016 · 1 comment · Fixed by #14
Closed

no-skip-test rule #3

sindresorhus opened this issue Jan 15, 2016 · 1 comment · Fixed by #14
Labels
assigned enhancement help wanted

Comments

@sindresorhus
Copy link
Member

It's easy to do make a test skipped with test.skip() and then forget about it. It's visible in the results, but still easily missed. Some projects/companies might want to prevent such tests from entering the CI.
@sindresorhus sindresorhus mentioned this issue Jan 15, 2016
Closed
@jackfranklin
Copy link

👍 for this - the amount of times a change like this (or in other libs, test.only) has made it onto CI is wayyy too high.

@sindresorhus sindresorhus mentioned this issue Jan 15, 2016
Closed
This was referenced Feb 21, 2016
Closed
Merged
sindresorhus added a commit that referenced this issue Feb 27, 2016
@sindresorhus
Merge pull request #14 from jfmengels/add-no-skip-test-rule
4615753 
add no-skip-test rule (fixes #3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add no-skip-test rule (fixes #3) jfmengels/eslint-plugin-ava
2 participants
@sindresorhus @jackfranklin