Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer-string-replace-all: Ignore regex with pipe #1962

Merged
merged 3 commits into from
Nov 14, 2022
Merged

prefer-string-replace-all: Ignore regex with pipe #1962

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35a68b5
`prefer-string-replace-all`: Ignore regex with pipe
hampuskraft Nov 14, 2022
fbbccdd
`prefer-string-replace-all`: Add test for invalid
hampuskraft Nov 14, 2022
f67a9f2
`prefer-string-replace-all`: Fix lint error
hampuskraft Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rules/prefer-string-replace-all.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const isRegexWithGlobalFlag = node =>

function isLiteralCharactersOnly(node) {
const searchPattern = node.regex.pattern;
return !/[$()*+.?[\\\]^{}]/.test(searchPattern.replace(/\\[$()*+.?[\\\]^{}]/g, ''));
return !/[$()*+.?[\\\]^{}|]/.test(searchPattern.replace(/\\[$()*+.?[\\\]^{}|]/g, ''));
}

function removeEscapeCharacters(regexString) {
Expand Down
1 change: 1 addition & 0 deletions test/prefer-string-replace-all.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ test({
'foo.replace(/[a]/g, bar)',
'foo.replace(/a?/g, bar)',
'foo.replace(/.*/g, bar)',
'foo.replace(/a|b/g, bar)',
hampuskraft marked this conversation as resolved.
Show resolved Hide resolved
'foo.replace(/\\W/g, bar)',
'foo.replace(/\\u{61}/g, bar)',
'foo.replace(/\\u{61}/gu, bar)',
Expand Down