Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless "recommended" properties #2355

Conversation

DEVTomatoCake
Copy link
Contributor

This removes the recommended property from rules with no apparent use, this just seems like an oversight from a Find and Replace to add the property after all description properties, however without ensuring that only those within the docs object are affected.

recommended itself is not used within these files, and it doesn't seem like they're used externally.

@fisker
Copy link
Collaborator

fisker commented May 11, 2024

Thanks. It's on me. I used a regular expression to search description, and add recommended in #2336.

@sindresorhus sindresorhus merged commit d2df181 into sindresorhus:main May 11, 2024
17 checks passed
@DEVTomatoCake DEVTomatoCake deleted the remove-useless-recommended-property branch May 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants