Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless "recommended" properties #2355

Merged
merged 1 commit into from
May 11, 2024
Merged

Remove useless "recommended" properties #2355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions rules/prefer-array-flat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ const arrayFlatMap = {
},
getArrayNode: node => node.callee.object,
description: 'Array#flatMap()',
recommended: true,
};

// `array.reduce((a, b) => a.concat(b), [])`
Expand Down Expand Up @@ -100,7 +99,6 @@ const arrayReduce = {
},
getArrayNode: node => node.callee.object,
description: 'Array#reduce()',
recommended: true,
};

// `[].concat(maybeArray)`
Expand All @@ -121,7 +119,6 @@ const emptyArrayConcat = {
return argumentNode.type === 'SpreadElement' ? argumentNode.argument : argumentNode;
},
description: '[].concat()',
recommended: true,
shouldSwitchToArray: node => node.arguments[0].type !== 'SpreadElement',
};

Expand Down Expand Up @@ -157,7 +154,6 @@ const arrayPrototypeConcat = {
return argumentNode.type === 'SpreadElement' ? argumentNode.argument : argumentNode;
},
description: 'Array.prototype.concat()',
recommended: true,
shouldSwitchToArray: node => node.arguments[1].type !== 'SpreadElement' && node.callee.property.name === 'call',
};

Expand Down
1 change: 0 additions & 1 deletion rules/prefer-modern-math-apis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ const create = context => {
data: {
replacement: `Math.${replacementMethod}(…)`,
description: 'Math.sqrt(…)',
recommended: true,
},
* fix(fixer) {
const {sourceCode} = context;
Expand Down
1 change: 0 additions & 1 deletion rules/prefer-structured-clone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const create = context => {
messageId: MESSAGE_ID_ERROR,
data: {
description: 'JSON.parse(JSON.stringify(…))',
recommended: true,
},
suggest: [
{
Expand Down