Add prefer-reflect-apply rule
#239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexzherdev
force-pushed
the
142-prefer-reflect-apply
branch
from
1466f68
to
2d7996a
Compare
|
👍 This looks good so far, except, if we consider discussion in #142 settled, it should also handle |
futpib
suggested changes
Apr 13, 2019
futpib
approved these changes
Apr 17, 2019
|
Something's wrong with p-queue in the integration test, including on master. |
alexzherdev
force-pushed
the
142-prefer-reflect-apply
branch
from
d7a84ea
to
c7a062e
Compare
sindresorhus
requested changes
May 22, 2019
rules/prefer-reflect-apply.js
Outdated
| if (fix) { | ||
| context.report({ | ||
| node, | ||
| message: 'Prefer Reflect.apply over Function.prototype.apply.', |
There was a problem hiding this comment.
Suggested change
| message: 'Prefer Reflect.apply over Function.prototype.apply.', | |
| message: 'Prefer `Reflect.apply()` over `Function#apply()`.', |
test/prefer-reflect-apply.js
Outdated
| invalid: [ | ||
| { | ||
| code: 'foo.apply(null, [42]);', | ||
| errors: [error], |
There was a problem hiding this comment.
errors should be below output.
test/prefer-reflect-apply.js
Outdated
| invalid: [ | ||
| { | ||
| code: 'foo.apply(null, [42]);', | ||
| errors: [error], |
There was a problem hiding this comment.
Suggested change
| errors: [error], | |
| errors, |
test/prefer-reflect-apply.js
Outdated
| const error = { | ||
| ruleId: 'prefer-reflect-apply', | ||
| message: 'Prefer Reflect.apply over Function.prototype.apply.' | ||
| }; |
There was a problem hiding this comment.
Can just be:
const errors = [
{
ruleId: 'prefer-reflect-apply'
}
];
rules/prefer-reflect-apply.js
Outdated
| const fixFunctionPrototypeCall = (node, sourceCode) => { | ||
| if ( | ||
| astUtils.getPropertyName(node.callee) === 'call' && | ||
| sourceCode.getText(node.callee.object) === 'Function.prototype.apply' && |
There was a problem hiding this comment.
I think it would be better to check the method chain in the actual AST, than comparing string representation of the resulting code.
|
@alexzherdev Ping :) |
alexzherdev
force-pushed
the
142-prefer-reflect-apply
branch
from
5e9d1b2
to
82656a0
Compare
|
@sindresorhus updated! |
|
🙌 Thanks for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142