prefer-string-slice: remove unsafe autofix for String#substr()
#2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
axetroy
changed the title
prefer-string-slice: fix autofix from .substr(start, length) when length equals to strings' length
…gth equals to strings' length
fisker
reviewed
Aug 21, 2024
rules/prefer-string-slice.js
Outdated
| @@ -67,7 +67,8 @@ function * fixSubstrArguments({node, fixer, context, abort}) { | |||
| if (argumentNodes.every(node => isNumber(node, scope))) { | |||
| const firstArgumentText = getParenthesizedText(firstArgument, sourceCode); | |||
|
|
|||
| yield fixer.insertTextBeforeRange(secondArgumentRange, `${firstArgumentText} + `); | |||
| yield fixer.insertTextBeforeRange(secondArgumentRange, `(${firstArgumentText} + `); | |||
| yield fixer.insertTextAfterRange(secondArgumentRange, ') || undefined'); | |||
There was a problem hiding this comment.
The original Math.min() already ugly, let's turn this fix into suggestion, I don't think people will use the fixed code directly.
There was a problem hiding this comment.
I admit, this is ugly, but I can't found a more elegant way to fix
There was a problem hiding this comment.
let's turn this fix into suggestion
Use suggestion instead.
There was a problem hiding this comment.
The source code is too complicated, and I don't have the confidence to refactor it. Close PR
fisker
changed the title
prefer-string-slice: fix autofix from .substr(start, length) when length equals to strings' lengthprefer-string-slice: remove unsafe autofix for String#substr()
|
Let's just remove the autofix not much value to provide a suggestion. |
fisker
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2291
When the second argument
lengthis equal to the length of the string,it will autofix to
.slice(start, 0)Now we make to
.slice(start, 0 || undefined)to align the behavior of.substr(start, length)