Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scope compare in consistent-function-scoping #562

Merged
merged 5 commits into from Feb 16, 2020
Merged

Fix scope compare in consistent-function-scoping #562

merged 5 commits into from Feb 16, 2020

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Feb 16, 2020 •
edited

Seems FunctionExpression and FunctionDeclaration has different scope, but they has the same block.

Fixes #374
Fixes #375

@sindresorhus sindresorhus merged commit ec4387c into sindresorhus:master Feb 16, 2020
@sindresorhus
Copy link
Owner

🙌

@fisker fisker deleted the issue-374 branch February 16, 2020 09:42
@kevinoid
Copy link

Solves both issues for me. Looks great. Thanks @fisker!

@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@fisker @sindresorhus @kevinoid