Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node.js 12 to testing #209

Merged
merged 1 commit into from Apr 29, 2019
Merged

Add Node.js 12 to testing #209

merged 1 commit into from Apr 29, 2019

Conversation

coreyfarrell
Copy link
Contributor

No description provided.

ehmicky
ehmicky approved these changes Apr 29, 2019
View reviewed changes
Copy link
Collaborator

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coreyfarrell for this PR! Looks good to me.

@coreyfarrell
Copy link
Contributor Author

@ehmicky not a problem. This is part of a series of mass changes (getting towards the end of my list), ref sindresorhus/meta#10.

@ehmicky
Copy link
Collaborator

ehmicky commented Apr 29, 2019

I am going to make this easier on @sindresorhus workload and directly merge this, because sindresorhus/meta#10 already suggests he is ok with the PR.

@sindresorhus please let me know if that is an issue.

@ehmicky ehmicky merged commit 9e5b976 into sindresorhus:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmicky ehmicky ehmicky approved these changes

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coreyfarrell @ehmicky