Treat the natural Node.js process termination as exit code 0 (#24)

Fixes #23
sindresorhus · Oct 22, 2022 · 69881e7 · 69881e7
1 parent a0f032e
commit 69881e7
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 6 deletions.
diff --git a/fixture-async.js → fixtures/async.js b/fixture-async.js → fixtures/async.js
@@ -1,5 +1,5 @@
 import process from 'node:process';
-import exitHook, {asyncExitHook, gracefulExit} from './index.js';
+import exitHook, {asyncExitHook, gracefulExit} from '../index.js';
 
 exitHook(() => {
 	console.log('foo');

diff --git a/fixtures/empty.js b/fixtures/empty.js
@@ -0,0 +1,5 @@
+import exitHook from '../index.js';
+
+exitHook(() => {
+	// https://github.com/sindresorhus/exit-hook/issues/23
+});
diff --git a/fixture.js → fixtures/sync.js b/fixture.js → fixtures/sync.js
@@ -1,5 +1,5 @@
 import process from 'node:process';
-import exitHook from './index.js';
+import exitHook from '../index.js';
 
 exitHook(() => {
 	console.log('foo');

diff --git a/index.js b/index.js
@@ -69,7 +69,7 @@ function addHook(options) {
 		isRegistered = true;
 
 		// Exit cases that support asynchronous handling
-		process.once('beforeExit', exit.bind(undefined, true, false, 0));
+		process.once('beforeExit', exit.bind(undefined, true, false, -128));
 		process.once('SIGINT', exit.bind(undefined, true, false, 2));
 		process.once('SIGTERM', exit.bind(undefined, true, false, 15));
 

diff --git a/test.js b/test.js
@@ -4,25 +4,34 @@ import execa from 'execa';
 import exitHook, {asyncExitHook} from './index.js';
 
 test('main', async t => {
-	const {stdout, stderr} = await execa(process.execPath, ['fixture.js']);
+	const {stdout, stderr, exitCode} = await execa(process.execPath, ['./fixtures/sync.js']);
 	t.is(stdout, 'foo\nbar');
 	t.is(stderr, '');
+	t.is(exitCode, 0);
+});
+
+test('main-empty', async t => {
+	const {stderr, exitCode} = await execa(process.execPath, ['./fixtures/empty.js']);
+	t.is(stderr, '');
+	t.is(exitCode, 0);
 });
 
 test('main-async', async t => {
-	const {stdout, stderr} = await execa(process.execPath, ['fixture-async.js']);
+	const {stdout, stderr, exitCode} = await execa(process.execPath, ['./fixtures/async.js']);
 	t.is(stdout, 'foo\nbar\nquux');
 	t.is(stderr, '');
+	t.is(exitCode, 0);
 });
 
 test('main-async-notice', async t => {
-	const {stdout, stderr} = await execa(process.execPath, ['fixture-async.js'], {
+	const {stdout, stderr, exitCode} = await execa(process.execPath, ['./fixtures/async.js'], {
 		env: {
 			EXIT_HOOK_SYNC: '1',
 		},
 	});
 	t.is(stdout, 'foo\nbar');
 	t.regex(stderr, /SYNCHRONOUS TERMINATION NOTICE/);
+	t.is(exitCode, 0);
 });
 
 test('listener count', t => {