Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining --force and --silent #64

Closed
thinkofapps opened this issue Jul 4, 2019 · 7 comments · Fixed by #73
Closed

Combining --force and --silent #64

thinkofapps opened this issue Jul 4, 2019 · 7 comments · Fixed by #73
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@thinkofapps
Copy link

thinkofapps commented Jul 4, 2019

Issuehunt badges

We need to kill a node process that runs a server (e.g. on port 8000) as part of our deployment script.

Using "fkill :8000" doesn't terminate the process, so we need "fkill -f :8000"

Unfortunately, fkill is returning an error code when there is no process running on port 8000. So we added the silent switch "fkill -f -s :8000"

This works, but gives an error message when no process has been found, which should not be the case using -s.


IssueHunt Summary

ulken ulken has been rewarded.

Backers (Total: $40.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@sindresorhus
Copy link
Owner

Yeah, that's a bug. It should work like you describe. PR welcome :)

@issuehunt-oss
Copy link

issuehunt-oss bot commented Jul 5, 2019

@issuehunt has funded $40.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jul 5, 2019
thinkofapps pushed a commit to thinkofapps/fkill-cli that referenced this issue Jul 5, 2019
@ulken
Copy link
Contributor

ulken commented Dec 15, 2019

I looked into this. I wasn't able to reproduce it when cloning the repository. However, when installing it from npm, it did indeed fail as described.

Reason: npm is not up-to-date with the repository. To be more precise, dependencies have been updated and fkill in particular. Version 6.2.0 introduced support for the silent option in fkill which fixes this issue.

Fix: Publish a new version with the current repository state to npm

@ulken
Copy link
Contributor

ulken commented Apr 7, 2020

@sindresorhus Thoughts on the above?

@sindresorhus
Copy link
Owner

@ulken The bounty is yours if you submit a test that shows that it's already fixed.

@ulken
Copy link
Contributor

ulken commented Apr 12, 2020

@sindresorhus

@issuehunt-oss
Copy link

issuehunt-oss bot commented Apr 13, 2020

@sindresorhus has rewarded $36.00 to @ulken. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants