Add forceAfterTimeout option
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sindresorhus Had lots of stuff on my hand + all the main/master shenanigans were killing me. On it again, will also comb through other unfinished/planned stuff. |
stroncium
force-pushed
the
fix-fkill-cli-42
branch
from
0c46b6b
to
d1914dc
Compare
stroncium
force-pushed
the
fix-fkill-cli-42
branch
from
d1914dc
to
39848a3
Compare
stroncium
force-pushed
the
fix-fkill-cli-42
branch
from
e9a2635
to
50baa69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add forceAfterTimeout option.
If not force killing, wait up to forceAfterTimeout number of milliseconds for process(es) to exit, then force kill the ones which didn't.
Is not used by default(no breaking change).
Unify windows behavior, if process filters SIGTERM, don't throw error(that is what is done for other platforms).
Added skips for title-related tests on Node v12 as it doesn't seem the issue with setting
process.titlewill ever be resolved(no moves on that front, v12 is going out of maintenance in a year).Required for sindresorhus/fkill-cli#80.
Fixes #44