Add Cache-Control #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whoa, the test fail? |
SamVerschueren
suggested changes
Jan 16, 2018
index.js
Outdated
| @@ -74,5 +75,6 @@ fetchRepos(); | |||
|
|
|||
| module.exports = (request, response) => { | |||
| controlAccess()(request, response); | |||
| response.setHeader("cache-control", cache) | |||
index.js
Outdated
| @@ -5,6 +5,7 @@ const controlAccess = require('control-access'); | |||
| const token = process.env.GITHUB_TOKEN; | |||
| const username = process.env.GITHUB_USERNAME; | |||
| const origin = process.env.ACCESS_ALLOW_ORIGIN; | |||
| const cache = "max-age=" + (process.env.CACHE_MAX_AGE || 300); | |||
There was a problem hiding this comment.
done (on etag commit)
single quotes and semicolons
|
You could add ETag too, which has much more effect, especially since the repos are only updates once a day. |
|
Looks good. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HTTP Header
cache-controlso that browsers can cache requests for short time, thus saving bandwidth in the long term.Also adds CACHE_MAX_AGE optional environment variable in case someone wish to modify that.