Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get-browser-globals.js and add additional update scripts for browser's environment. #166

Open
shapkarin opened this issue Jul 5, 2020 · 0 comments
Open

Fix get-browser-globals.js and add additional update scripts for browser's environment. #166

shapkarin opened this issue Jul 5, 2020 · 0 comments

Comments

@shapkarin
Copy link

I think that yours get-browser-globals.js don't works well test. Here what I got:

  • run script from get-browser-globals.js
  • copy my code to the json file
  • run npm run test
  • get an error that upperCase letter must be before LowerCased

So I also fix the get-browser-globals.js script to avoid that.
shapkarin added a commit to shapkarin/globals that referenced this issue Jul 5, 2020
@shapkarin
fix get-browser-globals.js script to pass the alphabetical order test c…
3c74fce 
…loses sindresorhus#166
@shapkarin shapkarin mentioned this issue Jul 5, 2020
Closed
shapkarin added a commit to shapkarin/globals that referenced this issue Jul 6, 2020
@shapkarin
change the way it gets browsers globals variables with get-browser-gl…
64a645b 
…obals.js script sindresorhus#166 sindresorhus#164
shapkarin added a commit to shapkarin/globals that referenced this issue Jul 6, 2020
@shapkarin
automate update browsers default scope [wip] sindresorhus#164 sindres…
aad6d7a 
…orhus#166
shapkarin added a commit to shapkarin/globals that referenced this issue Jul 6, 2020
@shapkarin
update docs how to update the browsers score [WIP] sindresorhus#164 s…
f32d182 
…indresorhus#166
@shapkarin shapkarin changed the title Fix get-browser-globals.js Fix get-browser-globals.js and add additional update scripts with jshint import. Jul 6, 2020
@shapkarin shapkarin changed the title Fix get-browser-globals.js and add additional update scripts with jshint import. Fix get-browser-globals.js and add additional update scripts. Jul 6, 2020
@shapkarin shapkarin changed the title Fix get-browser-globals.js and add additional update scripts. Fix get-browser-globals.js and add additional update scripts for browser's environment. Jul 6, 2020
shapkarin added a commit to shapkarin/globals that referenced this issue Jul 6, 2020
@shapkarin
fix sindresorhus#166 issue again
214f522
shapkarin added a commit to shapkarin/globals that referenced this issue Jul 6, 2020
@shapkarin
update/get-browser-globals/combine.js WIP sindresorhus#166
6d26f17
@shapkarin shapkarin mentioned this issue Jul 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve dev tools to update browser variables list. shapkarin/globals
1 participant
@shapkarin