New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GJS environment #73
Conversation
Can you link to some docs about it? |
The project page |
The globals are fetched from the gjs repl, like this:
|
It should only include globals not already included in |
Ok! Will amend tonight! |
GJS is a JavaScript environment used in the GNOME Project.
These were in
Maybe that's okay though? |
The ESLint recommended rules will complain about access to global variables that it doesn't know about. This is good, but ESLint doesn't yet know about the GJS environment. There is a PR (sindresorhus/globals#73) for the globals project on Github (which ESLint uses) to add the GJS environment and all its global variables. Until the above mentioned PR is merged, explicitly allow all default GJS global variables.
@mattiasb That's ok. |
LGTM |
@nzakas ? |
I'm curious, is the intent of adding these solely for use in ESLint? The reason I ask is that 2.0.0 (hopefully out next week) supports custom environments in plugins, so it might end up being better to have these in a plugin rather than this package. |
Yeah pretty much. Is the idea to move all environments to ESLint plugins in the future? What do I gain by putting this in a plugin instead of in here? :) |
@mattiasb the idea is to democratize environments so that anyone can create and share an environment without having to go through a gatekeeper. It's just not sustainable for us to have to keep adding every random JavaScript environment and library globals. |
That makes sense! :) Also if 2.0.0 is out around as soon as you I can just start with the latest beta. Thanks! |
We are aiming to have the final 2.0.0 out either this week or next week. |
The ESLint recommended rules will complain about access to global variables that it doesn't know about. This is good, but ESLint doesn't yet know about the GJS environment. There is a PR (sindresorhus/globals#73) for the globals project on Github (which ESLint uses) to add the GJS environment and all its global variables. Until the above mentioned PR is merged, explicitly allow all default GJS global variables.
The ESLint recommended rules will complain about access to global variables that it doesn't know about. This is good, but ESLint doesn't yet know about the GJS environment. There is a PR (sindresorhus/globals#73) for the globals project on Github (which ESLint uses) to add the GJS environment and all its global variables. Until the above mentioned PR is merged, explicitly allow all default GJS global variables.
The ESLint recommended rules will complain about access to global variables that it doesn't know about. This is good, but ESLint doesn't yet know about the GJS environment. There is a PR (sindresorhus/globals#73) for the globals project on Github (which ESLint uses) to add the GJS environment and all its global variables. Until the above mentioned PR is merged, explicitly allow all default GJS global variables.
GJS is a JavaScript environment used in the GNOME Project.