v9 not throwing ENOTDIR when cwd is a file

[chrisblossom]

This might be expected, but when using '.' as the pattern and specifying cwd as a file, an error is no longer thrown in v9 like it was in v8.

passing: chrisblossom/globby/v8-is-file/test.js#L199-L221
failing: chrisblossom/globby/v9-is-file/test.js#L218-L241

medusalix earned $20.00 by resolving this issue!

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on Issuehunt to raise funds.

[sindresorhus]

Would you be able to submit those tests as failing tests? That would help getting this fixed faster.

[IssueHuntBot]

@IssueHunt has funded $20.00 to this issue. See it on IssueHunt

[medusalix]

This is caused by an update to dir-glob version 2.2.1. The commit Add cwd option added the cwd option to dir-glob, which changed the way it treats the filepath passed to it:

2.0.0

const getPath = filepath => filepath[0] === '!' ? filepath.slice(1) : filepath;

2.2.1

const getPath = (filepath, cwd) => path.join(cwd, filepath[0] === '!' ? filepath.slice(1) : filepath);

@sindresorhus What should we do? Remove the failing tests?

[sindresorhus]

What should we do?

Add a check to ensure cwd is a directory.

[IssueHuntBot]

@sindresorhus has rewarded $18.00 to @medusalix. See it on IssueHunt

• 💰 Total deposit: $20.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $2.00