Skip to content

Commit

Permalink
Make the useElectron option false by default
Browse files Browse the repository at this point in the history
Fixes #359
Related to #315

`electron.net` is just too buggy.
  • Loading branch information
sindresorhus committed Oct 3, 2017
1 parent b55f79e commit 33cbb6f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ function normalizeArguments(url, opts) {
path: '',
retries: 2,
decompress: true,
useElectronNet: true
useElectronNet: false
},
url,
{
Expand Down
4 changes: 2 additions & 2 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,9 @@ If this is disabled, a compressed response is returned as a `Buffer`. This may b
###### useElectronNet

Type: `boolean`<br>
Default: `true`
Default: `false`

When used in Electron, Got will automatically use [`electron.net`](https://electron.atom.io/docs/api/net/) instead of the Node.js `http` module. It should be fully compatible, but you can turn it off here if you encounter a problem. Please open an issue if you do!
When used in Electron, Got will use [`electron.net`](https://electron.atom.io/docs/api/net/) instead of the Node.js `http` module. According to the Electron docs, it should be fully compatible, but it's not entirely. See [#315](https://github.com/sindresorhus/got/issues/315).


#### Streams
Expand Down

0 comments on commit 33cbb6f

Please sign in to comment.