Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace duplexify with something #135

Closed
floatdrop opened this issue Nov 20, 2015 · 4 comments
Closed

Replace duplexify with something #135

floatdrop opened this issue Nov 20, 2015 · 4 comments
Milestone
6.0.0

Comments

@floatdrop
Copy link
Contributor

duplexify is depending on quite big readable-stream package, so it would be nice to find alternative.
@floatdrop floatdrop added this to the 6.0.0 milestone Nov 20, 2015
@sindresorhus
Copy link
Owner

Lol, I was literally just writing this exact ticket :p

@sindresorhus
Copy link
Owner

When we depend on at least Node.js 4, I don't really see the point of having a dependency on readable-stream. It's huge.

@julien-f
Copy link
Contributor

Open a PR to make readable-stream optional :)

@sindresorhus
Copy link
Owner

Yup, that will be the first thing we'll try, unless we find a way to do what we need without it.

floatdrop added a commit that referenced this issue Nov 28, 2015
@floatdrop
replace duplexify with patched duplexer2
35075b9 
Closes #135
floatdrop added a commit that referenced this issue Dec 2, 2015
@floatdrop
replace duplexify with patched duplexer2
614ad28 
Closes #135
floatdrop added a commit that referenced this issue Dec 2, 2015
@floatdrop
replace duplexify with patched duplexer2
6da66b7 
Closes #135
@floatdrop floatdrop mentioned this issue Dec 2, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
3 participants
@sindresorhus @julien-f @floatdrop