updates oauth-1.0a example in readme #225
Conversation
| signature_method: 'HMAC-SHA1' | ||
| signature_method: 'HMAC-SHA1', | ||
| hash_function: (base_string, key) => { | ||
| return crypto.createHmac('sha1', key).update(base_string).digest('base64'); |
There was a problem hiding this comment.
Just make it an inline arrow function.
There was a problem hiding this comment.
like that: hash_function: (base_string, key) => crypto.createHmac('sha1', key).update(base_string).digest('base64') ? I'm ok with, but it's slightly harder to read or not?
There was a problem hiding this comment.
In that case, I tend to write things like this:
hash_function: (base_string, key) => crypto
.createHmac('sha1', key)
.update(base_string)
.digest('base64')There was a problem hiding this comment.
or const { createHmac } = require('crypto') then hash_function: (base_string, key) => createHmac('sha1', key).update(base_string).digest('base64')
and maybe base_string to base ?
shortest 1liner hash_function: (base, key) => createHmac('sha1', key).update(base).digest('base64')
There was a problem hiding this comment.
my comments are hard to read.. sorry :)
There was a problem hiding this comment.
Destructuring isn't supported in Node.js 4. Also, use camelCase instead of snake case.
| secret: process.env.CONSUMER_SECRET | ||
| }, | ||
| signature_method: 'HMAC-SHA1' | ||
| signature_method: 'HMAC-SHA1', | ||
| hash_function: (baseString, key) => crypto.createHmac('sha1', key).update(baseString).digest('base64'); |
|
thanks |
see v2.0.0 https://github.com/ddo/oauth-1.0a/releases/tag/2.0.0