Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BigInt detection #39

Closed
sindresorhus opened this issue Mar 2, 2018 · 9 comments · Fixed by #87
Closed

Support BigInt detection #39

sindresorhus opened this issue Mar 2, 2018 · 9 comments · Fixed by #87
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Mar 2, 2018

Issuehunt badges

http://2ality.com/2017/03/es-integer.html
https://groups.google.com/forum/#!msg/v8-dev/x571Gr0khNo/y8Jk0_vSBAAJ

Also BigInt64Array and BigUint64Array

Blocked by microsoft/TypeScript#15096

vladfrangu earned $40.00 by resolving this issue!

@sunilhari
Copy link

@sindresorhus Is it time already for this ??

https://twitter.com/v8js/status/991705626391732224

@transitive-bullshit
Copy link

transitive-bullshit commented May 21, 2018

It'll be a long while still before these v8 changes land in Node. See this node release list which details the supported versions of v8.

@Hoishin
Copy link
Sponsor

Hoishin commented May 22, 2018

Node already supports BigInt behind flag.
screen shot 2018-05-22 at 12 14 29

@Hoishin
Copy link
Sponsor

Hoishin commented May 24, 2018

Since this library is written in TypeScript, we probably have to wait for TypeScript to support BigInt, BigInt64Array, and BigUint64Array.
An issue is opened for this: microsoft/TypeScript#15096
And it is listed in TypeScript 3.0 milestone: https://github.com/Microsoft/TypeScript/milestone/70
It seems they started working on the milestone 2 weeks ago but only 2% are closed. It will still take time.

@sindresorhus
Copy link
Owner Author

@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@vladfrangu
Copy link
Contributor

Hello!

I'd like to help out with implementing support for BigInt and its Array types. What would I need to do to get started? Just create a PR?

@transitive-bullshit
Copy link

transitive-bullshit commented May 2, 2019

Hey @vladfrangu -- your help is very welcome 😄

I'd recommend opening a PR and following the patterns in the code and tests that all of the other types follow. Feel free to open a WIP PR and ask any questions you may have along the way.

Maybe just start with BigInt to keep the PR focused and then add support for the array types in a second pass.

Thanks!

@vladfrangu vladfrangu mentioned this issue May 2, 2019
2 tasks
@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label May 4, 2019
@IssueHuntBot
Copy link

@sindresorhus has rewarded $36.00 to @vladfrangu. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants