-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for BigInt #87
Conversation
Why are you removing Node.js 8 support? That seems unrelated. |
I thought nodejs 8 didn't have bigint support. Let me check real quick... |
We're not actually using BigInt, we're just detecting it, so we can still preserve support for Node.js 8. You can just comment out the tests for now. |
Yep, after reading your review, I realized you only did typeof / toString calls and checks, which would mean nodejs 8 support would still be present! I've done your requested changes now, as well as commented out all tests that only work on nodejs >=10. Hope this helps! |
@sindresorhus should be done now! If there's any other changes you'd like me to do, please let me know 👍 |
Nice work 👌 |
Fixes #39
Implements support for the BigInt, BigInt64Array and BigUint64Array
All tests pass