Fix merging of searchParams in create()/extend() (#335)

sindresorhus · May 4, 2021 · b3c9e88 · b3c9e88
1 parent eefcde5
commit b3c9e88
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/source/utils/merge.ts b/source/utils/merge.ts
@@ -49,10 +49,9 @@ export const deepMerge = <T>(...sources: Array<Partial<T> | undefined>): T => {
 
 			if (isObject((source as any).headers)) {
 				headers = mergeHeaders(headers, (source as any).headers);
+				returnValue.headers = headers;
 			}
 		}
-
-		returnValue.headers = headers;
 	}
 
 	return returnValue;

diff --git a/test/main.ts b/test/main.ts
@@ -494,6 +494,18 @@ test('ky.create() with deep array', async t => {
 	await server.close();
 });
 
+test('ky.create() does not mangle search params', async t => {
+	const server = await createHttpTestServer();
+	server.get('/', (request, response) => {
+		response.end(request.url);
+	});
+
+	const instance = ky.create({searchParams: {}});
+	t.is(await instance.get(server.url, {searchParams: {}}).text(), '/?');
+
+	await server.close();
+});
+
 test('ky.extend()', async t => {
 	const server = await createHttpTestServer();
 	server.get('/', (_request, response) => {