Fix merging of searchParams in create()/extend() #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sholladay
changed the title
|
Unfortunate timing with your PRs. Would you be able to fix the merge conflict? |
sholladay
force-pushed
the
fix-options-merge
branch
from
380a4c9
to
1493336
Compare
sholladay
changed the title
|
@sindresorhus fixed the merge conflicts. This and the other two PRs are ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #324
This PR fixes how the
searchParamsoption is handled inky.create()andky.extend()so that the user's expected search params are used. Previously, we were inadvertently adding aheaderssearch param in some cases.