Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the input argument #176

Merged
merged 4 commits into from
Sep 23, 2019
Merged

Validate the input argument #176

merged 4 commits into from
Sep 23, 2019

Conversation

himynameisdave
Copy link
Contributor

Display a meaningful error to the user if they attempt to provide an invalid input (for example, a Number).

Resolves #174

Copy link
Collaborator

@szmarczak szmarczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@himynameisdave
Copy link
Contributor Author

@szmarczak I have some failing tests on CI, but they appear to be breaking on master as well...

@szmarczak
Copy link
Collaborator

Ignore that. #168 - Travis is just too slow. You did it pretty good 👌

@sindresorhus sindresorhus changed the title Validate input Validate the input argument Sep 23, 2019
@sindresorhus sindresorhus merged commit 68959c4 into sindresorhus:master Sep 23, 2019
@sindresorhus
Copy link
Owner

Nice work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate input
3 participants