Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis #168

Open
sindresorhus opened this issue Aug 23, 2019 · 5 comments

Comments

@sindresorhus
Copy link
Owner

commented Aug 23, 2019

Issuehunt badges

https://travis-ci.com/sindresorhus/ky/jobs/227726270

Travis is slow. I think we might just need to increase the Puppeteer timeout somehow.


IssueHunt Summary

Backers (Total: $40.00)

Submitted pull Requests


Become a backer now!

Or submit a pull request to get the deposits!

Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@sholladay

This comment has been minimized.

Copy link
Collaborator

commented Aug 23, 2019

The three most recent Travis builds all failed in exactly the same way, always a TimeoutError and always on Node 10 but not Node 12. Seems kinda fishy, no? Also, it says the timeout is 30 seconds which seems pretty reasonable to me.

@sindresorhus

This comment has been minimized.

Copy link
Owner Author

commented Aug 23, 2019

Could be, but from experience, it's almost always Travis being slow, especially when the problem is only on older Node.js versions. Could also be a race issue in the code or test.

@szmarczak

This comment has been minimized.

Copy link
Collaborator

commented Sep 7, 2019

Could also be a race issue in the code or test.

It's not definitely a race issue. I've experienced it also when developing http2-wrapper.

@issuehunt-app

This comment has been minimized.

Copy link

commented Sep 10, 2019

@issuehunt has funded $40.00 to this issue.


@Ybrin

This comment has been minimized.

Copy link

commented Sep 13, 2019

I will give this a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.