Fix Deno and React Native compatibility #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
changed the title
sindresorhus
changed the title
|
It's there to show a friendly error if a user forgets to add the |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the line in
index.d.tsthat caused errors when trying to use the library in Deno. This resolves #294 and fixes #224.I have tested it on Deno 1.5.1 with Typescript 4.0.3 and it seems to work fine.
@sholladay mentioned that they want someone proficient in Typescript to analyze potential drawbacks from doing that, so I'm leaving it up to discussion since I'm far from an expert 馃槄