Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for ky.stop as return type in BeforeRetryHook TypeScript type #307

Merged
merged 4 commits into from
Dec 20, 2020
Merged

Fix support for ky.stop as return type in BeforeRetryHook TypeScript type #307

merged 4 commits into from
Dec 20, 2020

Conversation

rururux
Copy link
Contributor

@rururux rururux commented Dec 13, 2020

fixes #288

@sindresorhus
Copy link
Owner

It should be typed to the specific symbol. This also needs a type test.

@rururux
Copy link
Contributor Author

rururux commented Dec 13, 2020

ok, What should I do next?
Sorry for inconveniencing you.

@ialexi-bl ialexi-bl mentioned this pull request Dec 14, 2020
Merged
@sindresorhus
Copy link
Owner

What should I do next?

I wrote it in the last comment:

This also needs a type test.

@rururux
Copy link
Contributor Author

rururux commented Dec 19, 2020

I'm not confident, is this okay?

@sindresorhus sindresorhus changed the title add symbol to BeforeRetryHook returnment types Fix support for ky.stop as return type in BeforeRetryHook TypeScript type Dec 20, 2020
@sindresorhus sindresorhus merged commit b86ff0a into sindresorhus:master Dec 20, 2020
@rururux rururux deleted the patch-1 branch December 20, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BeforeRetryHook type definitions
2 participants
@rururux @sindresorhus