Fix BeforeRetryHook and NormalizedOptions TypeScript type definitions
#308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs type tests. https://github.com/sindresorhus/ky/blob/master/index.test-d.ts |
|
Can you rebase from |
…tions types to be indeed normalized
jabuj
force-pushed
the
fix/types-before-retry-normalized-options
branch
from
ec2450f
to
ae0772e
Compare
|
Eh, I'm not very familiar with rebases, I hope I didn't mess anything up |
sindresorhus
reviewed
Jan 4, 2021
sindresorhus
reviewed
Jan 4, 2021
sindresorhus
changed the title
BeforeRetryHook and NormalizedOptions TypeScript type definitions
|
Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #289 and fixes #288. The latter can be fixed by #307, but it doesn't include moving arguments that
BeforeRetryHookreceives to a separate object that can later be used to declarebeforeRetryhooks outside ofky.createdeclaration or actual request.