Fix throwHttpErrors: false suppressing non-HTTP errors #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sholladay
force-pushed
the
no-suppress-timeouts
branch
from
c6d27e9
to
9e2a31e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #246
This PR aims to fix some unintended behavior for people who use the
throwHttpErrors: falseoption. Previously, if the method was retriable, all operational errors would be suppressed, including network errors and timeout errors, not just HTTP status code errors. Now, the option only suppresses errors of theky.HTTPErrorclass, which are thrown when a response is received with a non-2xx status code.