Remove implicit dependency on wslvar binary (#198) #204
Conversation
|
I believe this would make 200 redundant (if accepted). |
| const wslAutoMountRoot = async () => { | ||
| let rootDirectory = '/mnt/'; | ||
| try { | ||
| const {stdout} = await pExecFile('awk', [ |
There was a problem hiding this comment.
Use JS for the parsing instead of awk.
| const paths = await pReaddir(rootDirectory); | ||
|
|
||
| /* eslint-disable no-await-in-loop */ | ||
| for (const path of paths) { |
There was a problem hiding this comment.
This can be done concurrently using Promise.all.
|
Can you describe your changes and why they're required? |
There was a problem hiding this comment.
Since this already adds a detection for wslAutoMountRoot, you could use that as well for the check on line 125 instead of hardcoding /mnt/ – that'd make my PR (#210) unnecessary :)
|
@tim-stasse Friendly bump :) |
|
@sindresorhus I think I can explain - An easy way to replace |
Fixes #198
Fixes #200