Change the spinner while ora is running?

[Bauke]

Hi, didn't see an issue for this while searching. Could it be possible to have some way of changing the current spinner while ora is running? From some testing there's no way to do this without having ora enter a newline. clear() only removes the spinner and not the text so it persists.

jeetiss earned $40.00 by resolving this issue!

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on Issuehunt to raise funds.

[sindresorhus]

It's not documented, but I think you can set instance.spinner = 'spinner-name';. We should get that documented and tested. PR welcome for that.

[Bauke]

That works but it breaks now and then, I assume because of frameIndex not being set back to 0 so it's trying to find a frame from the new spinner at an index that doesn't exist.

Code:

const ora = require('ora');
const spinners = require('cli-spinners');

const spinArray = [];

for (const spinner in spinners) {
  spinArray.push(spinners[spinner]);
}

const progress = ora('test').start();
progress.color = 'green';

setInterval(() => {
  progress.spinner = spinArray[Math.floor(Math.random() * spinArray.length)];
}, 1000);

[sindresorhus]

Ok. Thanks for testing.

[sindresorhus]

We should rename this.spinner to this._spinner and create a getter/setter (public interface) called spinner, that handles the logic of setting the spinner; the frame index logic and this:

ora/index.js

Lines 26 to 30 in bbc82a4

	this.spinner = typeof sp === 'object' ? sp : (process.platform === 'win32' ? cliSpinners.line : (cliSpinners[sp] || cliSpinners.dots)); // eslint-disable-line no-nested-ternary
	if (this.spinner.frames === undefined) {
	throw new Error('Spinner must define `frames`');
	}

[IssueHuntBot]

@issuehuntfest has funded $40.00 to this issue. See it on IssueHunt

[IssueHuntBot]

@IssueHunt has cancelled funding for this issue.(Cancelled amount: $40.00) See it on IssueHunt

[IssueHuntBot]

@IssueHunt has funded $40.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[IssueHuntBot]

@sindresorhus has rewarded $36.00 to @jeetiss. See it on IssueHunt

• 💰 Total deposit: $40.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $4.00