Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support changing the spinner while ora is running #95

Merged
merged 15 commits into from Feb 11, 2019
Merged

Support changing the spinner while ora is running #95

merged 15 commits into from Feb 11, 2019

Conversation

jeetiss
Copy link
Contributor

@jeetiss jeetiss commented Jan 24, 2019 •
edited by sindresorhus

Fixes #94

@jeetiss jeetiss changed the title Fix issue #94 Change the spinner while ora is running Jan 24, 2019
@sindresorhus sindresorhus mentioned this pull request Feb 4, 2019
Merged
@sindresorhus
Copy link
Owner

This also needs documentation updates.

sindresorhus
sindresorhus requested changes Feb 4, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Change the spinner while ora is running Support changing the spinner while ora is running Feb 4, 2019
@jeetiss
Copy link
Contributor Author

jeetiss commented Feb 4, 2019 •
edited

@sindresorhus thanks for review!
I change suggested things ^_^

I'm place link to all spinners in error message, not sure that's a good idea.

Do you understand what I wrote in README? I'm worried about my English)

sindresorhus
sindresorhus reviewed Feb 4, 2019
View reviewed changes
test.js Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Feb 4, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Feb 4, 2019
View reviewed changes
test.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Feb 4, 2019
View reviewed changes
test.js Outdated Show resolved Hide resolved
@sindresorhus @jeetiss
Apply suggestions from code review
773e62f 
Co-Authored-By: jeetiss <jeetiss@yandex.ru>
@sindresorhus
Copy link
Owner

Can you also add add a spinner change to the example.js, so people can see it in action? Like done here: 24ebe3b#diff-65d7f35d2dc8f88273f9b1e3438d3af2L16

@sindresorhus sindresorhus merged commit 2aee2da into sindresorhus:master Feb 11, 2019
@sindresorhus
Copy link
Owner

Looks good :)

@sindresorhus
Copy link
Owner

You need to submit the PR URL to IssueHunt to claim the bounty.

@jeetiss jeetiss deleted the change-spinner-when-run branch February 11, 2019 09:37
@sindresorhus
Copy link
Owner

sindresorhus commented Mar 3, 2019 •
edited

@jeetiss You need to submit the PR URL to IssueHunt to claim the bounty. https://issuehunt.io/repos/53072654/issues/94

Cancelled the funding because of lack of answer.

@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeetiss @sindresorhus