-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invert only the following predicate with the 'not' operator #71
Invert only the following predicate with the 'not' operator #71
Conversation
I was against this when we first added @SamVerschueren Thoughts? |
Makes sense. I'm ok with this change. Can you rebase against master? |
@SamVerschueren Should we remove |
I would be ok with removing it, although the error message might be slightly better with
|
@SamVerschueren Right now, yes, but the intention is to improve the negated errors messages. If we keep |
When I started implementing not, I was thinking about rephrasing messages automatically. I thought, If I always use I'm not saying we shouldn't drop |
@SamVerschueren Let's continue this over at #101 (Can you copy your above comment in there?) |
This PR changes the
not
operator from inverting all of the following predicates to only inverting the single following predicate.As ow is designed for human readability I believe that this is a more natural API (at least for English speakers) as the above code would be read
and
respectively.